Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: pandas 1.4: no longer use get_loc with method #6195

Merged
merged 1 commit into from
Jan 27, 2022
Merged

MAINT: pandas 1.4: no longer use get_loc with method #6195

merged 1 commit into from
Jan 27, 2022

Conversation

mathause
Copy link
Collaborator

Fixed as per @shoyer & @spencerkclark suggestion from #5721 (comment)

Now that pandas 1.4 is out it would be good to get this fixed (there are about 5000 warnings in our tests, mostly because of interp, though). Also leads to a warning in our docs which breaks them (although that can also be fixed with an :okwarning: directive).

@mathause mathause added dependencies Pull requests that update a dependency file topic-indexing topic-internals labels Jan 26, 2022
@thomasastanley thomasastanley mentioned this pull request Jan 27, 2022
Closed
@dcherian
Copy link
Contributor 

sphinx.errors.SphinxParallelError: RuntimeError: Non Expected warning in `/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/6195/doc/user-guide/computation.rst` line 374

Sphinx parallel build error:
RuntimeError: Non Expected warning in `/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/6195/doc/user-guide/computation.rst` line 374
[IPKernelApp] WARNING | Parent appears to have exited, shutting down.

RTD failure might be related (not obvious from looking at computation.rst)

@max-sixty
Copy link
Collaborator

Thanks @mathause , this looks great

@mathause
Copy link
Collaborator Author

RTD failure might be related

I just checked locally. This PR (+ #6194) fixes the doc build problem. It would require a lot of :okwarning: directives, so I suggest to merge this PR soonish instead of extending #6194.

@dcherian
Copy link
Contributor

Thanks @mathause

@dcherian dcherian merged commit 4692c59 into pydata:main Jan 27, 2022
@max-sixty
Copy link
Collaborator

I'll aim to do a release later

@mathause mathause deleted the remove_get_loc_method branch January 27, 2022 22:11
@gmaze gmaze mentioned this pull request Mar 2, 2022
Merged
@pnsaevik pnsaevik mentioned this pull request Oct 17, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file topic-indexing topic-internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pandas deprecates Index.get_loc with method
3 participants
@mathause @dcherian @max-sixty